Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docs and access checks in datalibs manager/api #4560

Merged
merged 2 commits into from Sep 6, 2017

Conversation

3 participants
@martenson
Copy link
Member

commented Sep 5, 2017

follow up for #4512

thanks @nsoranzo

@galaxybot galaxybot added this to the 17.09 milestone Sep 5, 2017

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Sep 5, 2017

lib/galaxy/managers/library_datasets.py:7:1: F401 'galaxy.exceptions.ItemAccessibilityException' imported but unused

@martenson martenson requested a review from nsoranzo Sep 5, 2017

@nsoranzo
Copy link
Member

left a comment

Thanks for the follow up!

@nsoranzo nsoranzo merged commit 37802ab into galaxyproject:dev Sep 6, 2017

6 checks passed

api test Build finished. 290 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@martenson martenson added this to Closed in Data Libraries Sep 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.