Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the robustness of Selenium workflow management tests. #4564

Merged
merged 1 commit into from Sep 6, 2017

Conversation

Projects
None yet
4 participants
@jmchilton
Copy link
Member

commented Sep 6, 2017

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Sep 6, 2017

I think we could "fix" this on the galaxy side by eliminating the separate workflow import page and moving the import view as a foldout/dropdown/modal to the main workflow overview page (2 page loads less should also be more pleasant to the user).

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2017

@mvdbeek True we should do that - but we should still refactor that import method into clicking a button and entering a URL as this PR does and we should still retry the atomic action of clicking the button if there are little issues the way this PR does. This is still a step toward writing better test cases for this usage even if it is a modal pop-up (which is a good idea).

@dannon

This comment has been minimized.

Copy link
Member

commented Sep 6, 2017

+1 to @mvdbeek's suggestion, and to the change here.

@dannon dannon merged commit 8f7d237 into galaxyproject:dev Sep 6, 2017

6 checks passed

api test Build finished. 290 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 44 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@mvdbeek

This comment has been minimized.

Copy link
Member

commented Sep 7, 2017

Right, right, I would have 👍 the PR if I had run the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.