Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make submitting logins for Selenium tests a bit more robust. #4576

Merged
merged 1 commit into from Sep 8, 2017

Conversation

Projects
None yet
2 participants
@jmchilton
Copy link
Member

commented Sep 7, 2017

There are a few different transiently failing tests on Jenkins that seem to fail because the test thinks Galaxy is logged in but it is not. So now after we click the login button in Selenium - we will wait for to see the "Register or Login" button turn into the "User" button.

This is a similar problem and fix to what was done in #4562 - which seemed to help.

Make submitting logins for Selenium tests a bit more robust.
There are a few different transiently failing tests on Jenkins that seem to fail because the test thinks Galaxy is logged in but it is not. So now after we click the login button in Selenium - we will wait for to see the "Register or Login" button turn into the "User" button.

This is a similar problem and fix to what was done in #4562 - which seemed to help.

@jmchilton jmchilton force-pushed the jmchilton:selenium_fixes_21 branch from ab07318 to 46b799d Sep 7, 2017

@martenson martenson merged commit 28fd37b into galaxyproject:dev Sep 8, 2017

6 checks passed

api test Build finished. 290 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 45 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Copy link
Member

commented Sep 8, 2017

Thanks for keeping on improving our tests John.

@martenson martenson added this to the 17.09 milestone Sep 8, 2017

@galaxyproject galaxyproject deleted a comment from galaxybot Sep 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.