Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datalibs: fix two bugs, refactor #4579

Merged
merged 2 commits into from Sep 11, 2017

Conversation

3 participants
@martenson
Copy link
Member

commented Sep 8, 2017

  • fixes JS errors when you refreshed page while on history import modal
  • fixes an error with dom traversing when trying to import data from history
  • refactor traversing parentElement to use closest() instead to prevent target mismatch

martenson added some commits Sep 8, 2017

@martenson martenson force-pushed the martenson:fix-reload-error branch from e288f2a to 5b87754 Sep 8, 2017

@galaxybot galaxybot added this to the 17.09 milestone Sep 8, 2017

@martenson martenson added this to Done in Data Libraries Sep 8, 2017

@jmchilton jmchilton merged commit 74a4860 into galaxyproject:dev Sep 11, 2017

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
api test Build finished. 290 tests run, 4 skipped, 0 failed.
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 45 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Sep 11, 2017

Looks great to me - thanks @martenson !

@martenson martenson deleted the martenson:fix-reload-error branch Sep 11, 2017

@martenson martenson moved this from Done to Closed in Data Libraries Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.