Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another issue with sorting by owner for published histories Selenium test. #4586

Merged
merged 2 commits into from Sep 10, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Sep 9, 2017

Locally this never happens, but remotely sometimes when sorting by owner the histories are sorted by owner but not in the same order as the test was asserting. I would assume this is likely a postgres vs. sqlite difference - perhaps the former doesn't sort the rows by the order they were created within equal sort classifications (i.e. same owner) but the latter does. I've fixed this - the test should not have been asserting such a strong condition I don't think.

This includes #4582 because it reused an abstraction introduced there so the diff is a bit messy. See b9cff7a for actual changes described here.

jmchilton added some commits Sep 8, 2017

Retry failed clicks more aggressively for Selenium tests.
Would have prevented from this (https://jenkins.galaxyproject.org/job/selenium/238/testReport/junit/selenium_tests.test_history_panel/HistoryPanelTestCase/test_refresh_preserves_state/) failure in retrospect. Also refactor that common pattern into a helper and use throughout. Add missing @selenium_test decorator on that test also - it would have retried if this had been there and we would have a screenshot.
Fix another issue with sorting by owner for published histories Selen…
…ium test.

Locally this never happens, but remotely sometimes when sorting by owner the histories are sorted by owner but not in the same order as the test was asserting. I would assume this is likely a postgres vs. sqlite difference - perhaps the former doesn't sort the rows by the order they were created within equal sort classifications (i.e. same owner) but the latter does. I've fixed this - the test should not have been asserting such a strong condition I don't think.

@galaxybot galaxybot added this to the 17.09 milestone Sep 9, 2017

@bgruening

This comment has been minimized.

Copy link
Member

commented Sep 10, 2017

Awesome!

@bgruening bgruening merged commit a21f05d into galaxyproject:dev Sep 10, 2017

6 checks passed

api test Build finished. 290 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 45 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.