Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Selenium tests for the Saved Histories #4587

Merged
merged 19 commits into from Sep 11, 2017

Conversation

Projects
None yet
4 participants
@anatskiy
Copy link
Contributor

commented Sep 10, 2017

This PR includes the following tests:

  • List of saved histories
  • Standard search
  • Advanced search (by name and tags)
  • History popup menu (switch, view, publish, rename, delete, undelete, delete permanently)
  • Multiple histories editing (delete, undelete)
  • Sort by name
  • Creating tags in the grid
  • Clicking on tags in the grid

@anatskiy anatskiy force-pushed the anatskiy:saved_histories_tests branch from 83f5702 to 8533c71 Sep 10, 2017

@galaxybot galaxybot added the triage label Sep 10, 2017

@galaxybot galaxybot added this to the 17.09 milestone Sep 10, 2017

Reduce duplication, increase robustness in Selenium history tests.
- set_tags() appeared in both published and saved history tests, refactored into navigates_galaxy with function name history_panel_add_tags
- is_displayed() appeared in both published and saved history tests, refactored into has_driver as selector_is_displayed
- Introduced history_panel_rename to reduce duplication across history panel tests and newer published and saved history tests.
- Removed custom history click option helper in saved and published history tests and just used the variant in navigates_galaxy.
- use wait_for_and_click a couple more places...
@jmchilton

This comment has been minimized.

Copy link
Member

commented Sep 10, 2017

Awesome - thanks @anatskiy. I made some modifications in e2730ca - let me know if any of that is a problem.

I'm a bit nervous about the publishing test in here - I know it runs fine on its own - but would it break the other publishing tests you contributed previously if they were all run together the way Jenkins would do it? Perhaps it is worth reworking both tests to just check items and orders of items in the list - rather than assert the full content of the published list - this way they would work together just fine. What do you think?

@jmchilton

This comment has been minimized.

Copy link
Member

commented Sep 10, 2017

@galaxybot test this

@bgruening bgruening added area/testing and removed triage labels Sep 10, 2017

@anatskiy

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2017

@jmchilton what if both tests will generate random history names and just check their presence in the grids? Will it solve the potential problem?

@jmchilton

This comment has been minimized.

Copy link
Member

commented Sep 11, 2017

@anatskiy Yeah - I like that a lot.

@anatskiy

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2017

@jmchilton I've just pushed the changes, please take a look.

Is there a way to wait until the grid is fully reloaded/refreshed? This would make the tests even more robust and remove extra time.sleep()

@jmchilton jmchilton merged commit 31f2168 into galaxyproject:dev Sep 11, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
lgtm analysis: JavaScript Running analyses for revisions
Details

@bgruening bgruening deleted the anatskiy:saved_histories_tests branch Sep 11, 2017

@jmchilton

This comment has been minimized.

Copy link
Member

commented Sep 11, 2017

@anatskiy I can't think of a way to wait on that exactly - I feel like the approach of trying the assertion checking if there are problems should cover that. That is what those function decorators do. If I come up with something more direct I will let you know though.

@jmchilton

This comment has been minimized.

Copy link
Member

commented Sep 11, 2017

Awesome thanks for the changes - this is great stuff!

@anatskiy

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2017

@jmchilton thanks to you for the improvements! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.