Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to workflow editor Selenium tests. #4592

Merged
merged 1 commit into from Sep 12, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Sep 11, 2017

I saw a failed test earlier that would have been fixed by a switch to wait_for_and_click in workflow_editor_click_options. This makes that switch and moves some of these workflow editor helper functions into navigates_galaxy.py for reuse by other test cases and by library users.

Small improvements to workflow editor Selenium tests.
I saw a failed test earlier that would have been fixed by a switch to wait_for_and_click in workflow_editor_click_options. This makes that switch and moves some of these workflow editor helper functions into navigates_galaxy.py for reuse by other test cases and by library users.
@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2017

Here is that test case failure. Luckily that failure triggered a retry and that whole run actually succeeded. Starting to see some blue dots on the sea of red in Jenkins.

@galaxybot galaxybot added this to the 17.09 milestone Sep 11, 2017

@dannon

This comment has been minimized.

Copy link
Member

commented Sep 12, 2017

Looks good, tests pass for me locally, too.

@dannon dannon merged commit 9468bef into galaxyproject:dev Sep 12, 2017

5 of 6 checks passed

framework test Build finished. No test results found.
Details
api test Build finished. 290 tests run, 5 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
integration test Build finished. 45 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.