Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write datatypes registry xml to working directory #4600

Merged

Conversation

Projects
None yet
4 participants
@mvdbeek
Copy link
Member

commented Sep 12, 2017

This addresses #4299.

@natefoo can you review this ? I think you'd be happy if that ended up in 17.09, but since we classified this as a bug we may get around that.
Also I'm not sure about the changes to the pulsar runner, does this look OK to you @jmchilton ?

@jmchilton jmchilton merged commit 52436aa into galaxyproject:dev Sep 13, 2017

6 checks passed

api test Build finished. 292 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 45 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Sep 13, 2017

Thanks a ton @mvdbeek - if you want to continue unwinding this thread I created #4609 ;)

@natefoo

This comment has been minimized.

Copy link
Member

commented Sep 13, 2017

Thanks @mvdbeek! I didn't get a chance to fully review it before the merge but i'll let you know if I notice anything when I do get a chance to look at it.

@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2017

Thanks for the merge! #4609 sounds like a very good idea.

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Sep 15, 2017

I've started seeing #4299 frequently, not only when the cron job deletes the temporary file, but also when the handler is restarted while the job is running (I think). Can we backport (part of) it?

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Sep 15, 2017

the handler is restarted

Actually I think it changes also when the toolbox is reloaded.

@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2017

Yeah, I can backport it.

mvdbeek added a commit to mvdbeek/galaxy that referenced this pull request Sep 16, 2017

martenson added a commit that referenced this pull request Sep 16, 2017

Merge pull request #4633 from mvdbeek/backport_registry_to_working_dir
[17.05] Backport #4600: Write datatypes registry xml to working directory

@mvdbeek mvdbeek deleted the mvdbeek:datatypes_registroy_in_working_directory branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.