New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused abstraction layers from Visualizations Registry #4620

Merged
merged 31 commits into from Sep 21, 2017

Conversation

Projects
None yet
3 participants
@guerler
Contributor

guerler commented Sep 14, 2017

This consolidates the visualization framework by folding back unused abstraction layers. It should not change any functionality. Previously a base plugin manager was inherited by a page serving plugin manager which then was inherited by the visualization registry across directories while each was overloading substantial functionality. The code reduction in this PR highlights that. Only the visualization registry used this inheritance chain. For other plugin types such as webhooks and tours inheriting these base classes was not helpful. Also moving forward it does not seem that these base classes will be needed anywhere else than for visualizations (which should probably be referred to as pageserving plugins).

This PR will make it easier for us to work with the visualization framework and to integrate "Charts" as its client-side interface, see also #4256.

@guerler guerler added the status/WIP label Sep 14, 2017

@guerler guerler added this to the 18.01 milestone Sep 14, 2017

@guerler guerler changed the title from [WIP] Consolidate visualization framework to Consolidate visualization framework Sep 15, 2017

@guerler

This comment has been minimized.

Contributor

guerler commented Sep 15, 2017

@galaxybot test this

@nsoranzo

This comment has been minimized.

Member

nsoranzo commented Sep 15, 2017

@guerler I think you have to remove some unit test files:

  • test/unit/web/base/test_HookPluginManager.py
  • test/unit/web/base/test_PageServingPluginManager.py
  • test/unit/web/base/test_PluginManager.py
@guerler

This comment has been minimized.

Contributor

guerler commented Sep 15, 2017

@nsoranzo awesome, thank you for pointing that out.

@guerler guerler added status/review and removed status/WIP labels Sep 17, 2017

@guerler guerler changed the title from Consolidate visualization framework to Remove unused abstraction layers from Visualizations Registry Sep 20, 2017

@jmchilton jmchilton merged commit e057d7d into galaxyproject:dev Sep 21, 2017

6 checks passed

api test Build finished. 292 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 45 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Member

jmchilton commented Sep 21, 2017

Thanks for working on this @guerler - looks pretty good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment