Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated function description and fix some typos #4629

Merged
merged 4 commits into from Sep 15, 2017

Conversation

Projects
None yet
3 participants
@VJalili
Copy link
Member

commented Sep 15, 2017

Changed "Returns" to "Sets" in functions on model which set a value, and fixed some typos.

@galaxybot galaxybot added the triage label Sep 15, 2017

@galaxybot galaxybot added this to the 17.09 milestone Sep 15, 2017

@@ -2035,7 +2035,7 @@ def get_size(self, nice_size=False):
return self.dataset.get_size()

def set_size(self):
"""Returns the size of the data on disk"""
"""Sets the size of the data on disk"""

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Sep 15, 2017

Member

This method actually sets and returns the dataset size.

This comment has been minimized.

Copy link
@VJalili

VJalili Sep 15, 2017

Author Member

Thanks, updated.

VJalili added some commits Sep 15, 2017

@VJalili VJalili changed the title Updated function description Updated function description and fix some typos Sep 15, 2017

@nsoranzo nsoranzo merged commit ea7b274 into galaxyproject:dev Sep 15, 2017

2 of 6 checks passed

api test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
framework test Test started.
Details
lgtm analysis: JavaScript Running analyses for revisions
Details
integration test Build finished. 45 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.