New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload tools if a macro changes #4635

Merged
merged 2 commits into from Sep 21, 2017

Conversation

Projects
None yet
3 participants
@mvdbeek
Member

mvdbeek commented Sep 17, 2017

We do this by recording any macro that is required to load a tool. When
loading a tool we register the macro to be watched, and if the macro changes we
reload all corresponding tools.

xref: #3987

Reload tools if a macro changes
We do this by recording any macros that are required to load a tool.  When
loading a tool we register the macro to be watched, and if the macro changes we
reload all corresponding tools.

@mvdbeek mvdbeek added status/review and removed status/WIP labels Sep 19, 2017

@jmchilton

This comment has been minimized.

Member

jmchilton commented Sep 21, 2017

Working on a PR commit to preserve some backward compatibility with this - this doesn't break anything in Galaxy but it will break Planemo.

Rework #4635 to preserve backward compatibility on modules shared via…
… galaxy-lib.

Also cleanup comments and such in xml_macros to reflect this doesn't apply just to tools.
@jmchilton

This comment has been minimized.

Member

jmchilton commented Sep 21, 2017

@mvdbeek does d3d1340 look okay to you?

@mvdbeek

This comment has been minimized.

Member

mvdbeek commented Sep 21, 2017

much better, thanks a lot @jmchilton !

@jmchilton jmchilton merged commit 87d5d44 into galaxyproject:dev Sep 21, 2017

0 of 6 checks passed

api test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
framework test Test started.
Details
integration test Test started.
Details
lgtm analysis: JavaScript Running analyses for revisions
Details
toolshed test Test started.
Details
@jmchilton

This comment has been minimized.

Member

jmchilton commented Sep 21, 2017

I'm already super excited for 18.01 - this is very cool @mvdbeek - thanks!

nsoranzo added a commit to nsoranzo/galaxy that referenced this pull request Sep 29, 2017

nsoranzo added a commit to nsoranzo/galaxy that referenced this pull request Sep 29, 2017

mvdbeek added a commit to bardin-lab/galaxy that referenced this pull request Dec 10, 2017

Rework galaxyproject#4635 to preserve backward compatibility on modul…
…es shared via galaxy-lib.

Also cleanup comments and such in xml_macros to reflect this doesn't apply just to tools.

@mvdbeek mvdbeek deleted the mvdbeek:reload_on_macro_changes branch Aug 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment