Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Fix links on workflow, history items. #4656

Merged
merged 1 commit into from Sep 21, 2017

Conversation

Projects
None yet
3 participants
@dannon
Copy link
Member

commented Sep 20, 2017

Added a small layer to support modern routes in old display_base pages (workflow, history, etc).

Without this bugfix, the following links go to the big blob of json that replaced these endpoints.

image

Small (temporary, mako is going away) layer to support modern routes …
…in old display_base pages (workflow, history, etc).
@dannon

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2017

@guerler This is (minor) fallout from the grid swapover, but we should probably look for similar things. I found this one accidentally.

@guerler

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2017

Thanks, looking for similar cases. Do you know whats wrong with the tests?

@dannon

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2017

@guerler Just looking at the output, it seems like jenkins ran out of disk space?

@jmchilton jmchilton merged commit c9aead9 into galaxyproject:release_17.09 Sep 21, 2017

6 checks passed

api test Build finished. 292 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@dannon dannon added this to the 17.09 milestone Sep 21, 2017

@galaxyproject galaxyproject deleted a comment from galaxybot Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.