New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium fixes for publishing histories button. #4660

Merged
merged 1 commit into from Sep 21, 2017

Conversation

Projects
None yet
4 participants
@jmchilton
Member

jmchilton commented Sep 20, 2017

@martenson

This comment has been minimized.

Member

martenson commented Sep 20, 2017

I do not think Toastr uses <div class="modal-backdrop fade in"> - this is probably some modal dialogue disappearing?

@jmchilton

This comment has been minimized.

Member

jmchilton commented Sep 20, 2017

This is in setUp so I'm not sure... https://jenkins.galaxyproject.org/job/selenium/488/artifact/488-test-errors/. There are some screenshots for these tests but I'm not sure which one this maps too.

@martenson

This comment has been minimized.

Member

martenson commented Sep 20, 2017

@jmchilton I went through all of these already and this one seems related this

@jmchilton

This comment has been minimized.

Member

jmchilton commented Sep 21, 2017

@martenson I'm not sure what the popup - I'm sure you are right that it isn't toastr - but it seems like it going away whatever it is right? So this fix should still be valid I think.

@martenson

This comment has been minimized.

Member

martenson commented Sep 21, 2017

@jmchilton I agree, sorry for derailing the PR.

@martenson martenson merged commit 98f2c10 into galaxyproject:dev Sep 21, 2017

4 of 6 checks passed

api test Build finished. 292 tests run, 4 skipped, 1 failed.
Details
toolshed test Build finished. No test results found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
@mvdbeek

This comment has been minimized.

Member

mvdbeek commented Sep 21, 2017

@martenson I'm not sure what the popup - I'm sure you are right that it isn't toastr - but it seems like it going away whatever it is right? So this fix should still be valid I think.

That is the hover for dragging datasets for upload in there. I guess I broke this in #4476

@martenson

This comment has been minimized.

Member

martenson commented Sep 21, 2017

@mvdbeek you mean in the screenshot I added? I doubt that is the case. Are we even testing drag&drop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment