New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Pass job output file unqualified names to Pulsar so that it can create them before running the job #4662

Merged
merged 2 commits into from Sep 22, 2017

Conversation

Projects
None yet
2 participants
@natefoo
Member

natefoo commented Sep 20, 2017

Fixes a bug whereby detailed error reporting is not possible when using Pulsar and the job doesn't create its outputs. In this case, Pulsar attempts to stage the outputs back to Galaxy, fails, and the output dataset message is set to the generic Remote job server indicated a problem running or monitoring this job. message.

Cannot be merged or run tests until Pulsar 0.7.5 is released (which will be soon).

xref galaxyproject/pulsar#141

@natefoo natefoo added this to the 18.01 milestone Sep 20, 2017

@jmchilton

This comment has been minimized.

Member

jmchilton commented Sep 21, 2017

This requires a pulsar release right? The failed Travis tests seem to indicate that.

@natefoo

This comment has been minimized.

Member

natefoo commented Sep 21, 2017

Yes, working on finishing that release now that my other PRs are merged.

I am running this code plus #4663 and #4622 on Test and running Test's Pulsar on Bridges at HEAD + galaxyproject/pulsar#141 + galaxyproject/pulsar#136 + natefoo/galaxy-lib@add5c5e, so it is working in a production setup.

@natefoo natefoo changed the base branch from dev to release_17.09 Sep 21, 2017

@natefoo natefoo changed the title from Pass job output file unqualified names to Pulsar so that it can create them before running the job to [17.09] Pass job output file unqualified names to Pulsar so that it can create them before running the job Sep 21, 2017

@natefoo

This comment has been minimized.

Member

natefoo commented Sep 21, 2017

We're gonna need #4674 to be able to run tests.

@jmchilton jmchilton merged commit 27a28e2 into galaxyproject:release_17.09 Sep 22, 2017

6 checks passed

api test Build finished. 292 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment