Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.07] Fix modules resolver #4663

Merged
merged 1 commit into from Sep 21, 2017

Conversation

Projects
None yet
3 participants
@natefoo
Copy link
Member

commented Sep 21, 2017

The addition of the resolver_msg property on the base Dependency class references name and version attributes that were not defined in ModuleDependecy.

If this is merged I'll merge it forward through the stable releases to dev. I also need it in galaxy-lib so I can use it with Pulsar.

What milestone do I attach to this?

Fix modules resolver (addition of the resolver_msg property on the base
class references name and version attributes that were not defined in
the ModuleDependecy).

@natefoo natefoo changed the title [16.04] Fix modules resolver [16.07] Fix modules resolver Sep 21, 2017

@nsoranzo nsoranzo added this to the 17.09 milestone Sep 21, 2017

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Sep 21, 2017

@natefoo The milestone for the next Galaxy to be released, so it is added to the release notes.

@natefoo

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2017

Thanks!

@jmchilton

This comment has been minimized.

Copy link
Member

commented Sep 21, 2017

Thanks for the fix - has it been broken since 16.07? I thought I had tested it as late as like 17.05. Ping me when it is in Galaxy and I can do the galaxy-lib update and release for you. Are you using this on bridges?

@natefoo

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2017

It's broken in 16.07 as far as I can tell, as that's the first release that included resolver_msg: 8616c0e. Github claims it's 16.10, but I see it in the 16.07 branch (probably backported post-tag?).

@natefoo

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2017

I'm using it on Bridges via Pulsar, yeah.

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Sep 21, 2017

Original PR for 16.10 was #2917, backported to 16.07 in #2918.

@nsoranzo nsoranzo merged commit 2ffeedf into galaxyproject:release_16.07 Sep 21, 2017

5 of 6 checks passed

integration test Build finished. No test results found.
Details
api test Build finished. 224 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 112 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
@natefoo

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2017

@nsoranzo thanks!

@jmchilton should be good to go for a galaxy-lib release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.