Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Remove chatty debug statement #4671

Merged
merged 1 commit into from Sep 23, 2017

Conversation

Projects
None yet
4 participants
@dannon
Copy link
Member

commented Sep 21, 2017

This happens pretty often and much of the time is not a problem at all. If we have to track down any new issues with workflow output cleanup, it's easy enough to temporarily reintroduce this logging.

It's not reeealy a bugfix, but it does make logs easier to filter and read. And it's definitely not the kind of 'enhancement' the freeze is designed to prevent merging/work on. I feel like this follows the spirit of the rules, if not exactly.

Remove overly chatty debug statement in workflow output cleanup -- th…
…is happens pretty often and much of the time is not a problem at all. If we have to track down any new issues with workflow output cleanup, it's easy enough to temporarily add this logging.
@martenson

This comment has been minimized.

Copy link
Member

commented Sep 21, 2017

Would downgrading it to warning help?

@dannon

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2017

@martenson Warning is worse than debug, right? (and, by worse I mean it'd actually be upgrading it in severity/filtering, not downgrading it)

@martenson

This comment has been minimized.

Copy link
Member

commented Sep 21, 2017

Right, disregard that. 🙄

@dannon

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2017

Swapped to TRACE level in #4672

@galaxybot galaxybot added the triage label Sep 21, 2017

@dannon dannon added kind/bug status/review and removed triage labels Sep 21, 2017

@jmchilton jmchilton merged commit 7896413 into galaxyproject:release_17.09 Sep 23, 2017

6 checks passed

api test Build finished. 292 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Sep 23, 2017

Thanks @dannon !

@galaxybot

This comment has been minimized.

Copy link

commented Sep 23, 2017

This PR was merged without a milestone attached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.