New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove visualization edit form mako #4682

Merged
merged 14 commits into from Sep 26, 2017

Conversation

Projects
None yet
2 participants
@guerler
Contributor

guerler commented Sep 23, 2017

Branched from and analogous to #4681. Removes visualization edit form mako and uses client-side form builder instead. This PR also removes the Trackster specific create form, other visualizations cannot be created using this form since they require associated datasets.

@jmchilton

This comment has been minimized.

Member

jmchilton commented Sep 26, 2017

Is this ready to be taken out of WIP? I'm +1 on this.

@guerler guerler added status/review and removed status/WIP labels Sep 26, 2017

@guerler

This comment has been minimized.

Contributor

guerler commented Sep 26, 2017

Yep, thx @jmchilton. Just merged dev into it.

@jmchilton jmchilton merged commit df14b8d into galaxyproject:dev Sep 26, 2017

0 of 6 checks passed

api test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
framework test Test started.
Details
integration test Test started.
Details
lgtm analysis: JavaScript Running analyses for revisions
Details
toolshed test Test started.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment