New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ever more Selenium fixes. #4687

Merged
merged 9 commits into from Sep 25, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Member

jmchilton commented Sep 24, 2017

This PR mirrors #4676 - it is an aggregation of one-off fixes for transient failures in Selenium tests. See each commit for a fuller description and in most cases a link to a failed attempt to run a test corresponding to the fix.

Current state of the tests (we did have a run of 17 straight test suite successes Sunday morning):

screen shot 2017-09-24 at 5 10 26 pm

jmchilton added some commits Sep 23, 2017

Selenium - bug fix for history test options.
Wait on something useful instead of picking an arbitrary sleep time and praying.
Selenium - fix transient error in history switching test.
History sometimes takes longer than that second to switch in the GUI, so start a retry cycle on that assertion after a half a second.

xref https://jenkins.galaxyproject.org/job/selenium/586/artifact/586-test-errors/test_history_switch2017092413201506273602/stacktrace.txt
Selenium - fix transiently failing test caused by not waiting on anon…
…ymous history loading.

After logging out - may need to a wait a second to give the UI and backend a chance to create a new history for the now anoymous user. Pause and let that happen.

xref https://jenkins.galaxyproject.org/job/selenium/585/artifact/585-test-errors/test_clean_anon_history_after_logout2017092412041506269041/
@martenson

This comment has been minimized.

Member

martenson commented Sep 25, 2017

All of these look good, thank you for making it so easy to review @jmchilton.

@martenson martenson merged commit 1c2c595 into galaxyproject:dev Sep 25, 2017

6 checks passed

api test Build finished. 292 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment