Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Update versions of conda and conda-build #4701

Conversation

Projects
None yet
3 participants
@nsoranzo
Copy link
Member

commented Sep 26, 2017

Creating environments for (some) Python packages now requires conda 4.3 due to the conda-forge python:

$ conda create -n __crossmap@0.2.2 crossmap=0.2.2
Fetching package metadata ...............
...
Linking packages ...
Installing conda-forge::wheel-0.30.0-py_1 requires a minimum conda version of 4.3.
Update versions of conda and conda-build
Creating environments for (some) Python packages now requires conda 4.3 due
to the conda-forge `python`:

```
$ conda create -n __crossmap@0.2.2 crossmap=0.2.2
Fetching package metadata ...............
...
Linking packages ...
Installing conda-forge::wheel-0.30.0-py_1 requires a minimum conda version of 4.3.
```
@natefoo

This comment has been minimized.

Copy link
Member

commented Sep 26, 2017

Since this updates to a version of 4.3 where --offline is (mostly) fixed, we should also update build_isolated_environment() to permit the use of --offline with 4.3.

@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2017

@natefoo Do you know in which minor revision of conda 4.3 the --offline problem was fixed? Unfortunately we cannot just always enable the option because we don't have full control on the conda version that Galaxy will use, so we need to update this line:

offline_works = conda_context.conda_version < LooseVersion("4.3")

Feel free to push to my branch if you want.

@natefoo

This comment has been minimized.

Copy link
Member

commented Sep 27, 2017

4.3.18 should fix it for most cases (conda/conda#4798) although it's still not 100% fixed when the local conda install is read only (conda/conda#5370). But I think it's better that we attempt it for 4.3.18+ rather than continue with the broken --use-index-cache behavior. Those of us who use CVMFS (ping @dmorais) can work around it by ensuring dependencies are mulled.

@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2017

Thanks @natefoo!

@jmchilton jmchilton merged commit 1c5c046 into galaxyproject:release_17.09 Sep 27, 2017

6 checks passed

api test Build finished. 292 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:release_17.09_update_conda_version branch Sep 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.