Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Add message (error and info) display to workflows display list. #4716

Merged
merged 6 commits into from Sep 27, 2017

Conversation

Projects
None yet
5 participants
@dannon
Copy link
Member

commented Sep 27, 2017

This fixes #4712.

Not a huge fan of the toastr display, but it's the only mechanism this page uses to display messages; reused it for consistency.

I also came across and fixed another two bugs while I was at it. One undefined variable that'd be hit in particular situations, and another error generating the context menu for workflows shared to you.

@nsoranzo nsoranzo added this to the 17.09 milestone Sep 27, 2017

@nsoranzo nsoranzo changed the title Add message (error and info) display to workflows display list. [17.09] Add message (error and info) display to workflows display list. Sep 27, 2017

@dannon

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2017

@nsoranzo Thanks for the tags, etc., but not quite for review yet.

@dannon dannon added status/WIP and removed status/review labels Sep 27, 2017

@dannon

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2017

Ok, now it's ready! (fixed a few more bugs while I was at it)

@dannon dannon added status/review and removed status/WIP labels Sep 27, 2017

dannon and others added some commits Sep 27, 2017

@dannon

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2017

Since it's reasonably closely related, @guerler suggested combining #4717 here, so that changeset has been cherry-picked into this branch for easier review/merging.

@guerler

This comment has been minimized.

Copy link
Contributor

commented Sep 27, 2017

👍

@guerler guerler merged commit 407da92 into galaxyproject:release_17.09 Sep 27, 2017

1 of 6 checks passed

api test Test scheduled.
Details
framework test Test scheduled.
Details
integration test Test scheduled.
Details
lgtm analysis: JavaScript Running analyses for revisions
Details
toolshed test Test scheduled.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mvdbeek

This comment has been minimized.

Copy link
Member

commented Sep 28, 2017

Thanks @dannon!

@blankenberg

This comment has been minimized.

Copy link
Member

commented Sep 28, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.