Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[17.09] If the newest version of a tool is hidden, load the newest older version, if any, into the tool panel #4726
With recent tool lineage handling that always uses tool version comparisons instead of installation order from the database (I think this is how it worked before?), we have some "broken" tool versions that show up as newer versions of tools that should in fact be older.
For example, at one point we had installed
>>> from distutils.version import LooseVersion >>> LooseVersion('18.104.22.168-3') > LooseVersion('freebayes-0.9.14') False >>>
Because tools are loaded into the panel regardless of whether they're hidden and, and newer versions replace older versions, and only at runtime are hidden tools filtered out, if the "newest" version is hidden, no version will show up in the panel. This change allows the "newest" unhidden version to appear.
Here are two things probably worth being aware of:
On gitter we considered adding a forever-hack to the lineage module to fix this for this specific tool (and any others that we might encounter), but this newest-version-hiding fix was deemed more palatable.
The original intent was for them just to be hidden from the tool panel, I think the versions dropdown is supposed to have them, although we could add a new attribute (e.g.
Also, rather than a tool-specific hack, we could introduce