[15.05] Quote more paths when building metadata command lines. #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested and fixes linked library uploads with spaces in the file path. Probably fixes other more obsecure problems like if the temp directory had a space in it, etc....
|
👍 |
1 similar comment
|
+1 |
blankenberg
added a commit
that referenced
this pull request
Jul 17, 2015
[15.05] Quote more paths when building metadata command lines.
blankenberg
added a commit
to blankenberg/galaxy
that referenced
this pull request
Jul 17, 2015
…ixes issue that appears as a result of PR galaxyproject#474, but also could occur under corner-cases with interestlying named temp filenames. Also, add quotes around configfile filename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested and fixes linked library uploads with spaces in the file path. Probably fixes other more obscure problems like if the temp directory had a space in it, etc....
Problem reported here - https://www.mail-archive.com/galaxy-dev@lists.galaxyproject.org/msg01397.html by Joseph Brent Greer.