Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Fix missing support for command_inject when using containers lib in GIEs #4740

Merged
merged 2 commits into from Oct 5, 2017

Conversation

Projects
None yet
2 participants
@natefoo
Copy link
Member

commented Oct 3, 2017

Otherwise there's no way to set e.g. $DEFAULT_CONTAINER_TIMEOUT on a per-GIE basis. Eventually we should abstract this but that will require many changes to the GIE config.

@natefoo natefoo added this to the 17.09 milestone Oct 3, 2017

@natefoo natefoo referenced this pull request Oct 3, 2017

Open

GIE Hardening #4651

9 of 21 tasks complete

@natefoo natefoo added status/WIP and removed status/review labels Oct 4, 2017

@natefoo natefoo changed the title [17.09] Fix missing support for command_inject when using containers lib in GIEs [WIP] [17.09] Fix missing support for command_inject when using containers lib in GIEs Oct 4, 2017

@natefoo natefoo changed the title [WIP] [17.09] Fix missing support for command_inject when using containers lib in GIEs [17.09] Fix missing support for command_inject when using containers lib in GIEs Oct 4, 2017

@natefoo natefoo added status/review and removed status/WIP labels Oct 4, 2017

@natefoo

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2017

Un-WIP'd, I thought I might include a fix for launch dataset fetching in this PR.

@jmchilton jmchilton merged commit 8c769b2 into galaxyproject:release_17.09 Oct 5, 2017

6 checks passed

api test Build finished. 292 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@natefoo

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2017

Thanks @jmchilton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.