Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Fix t, a, g, s returned in to_dict() method #4742

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
2 participants
@mvdbeek
Copy link
Member

commented Oct 3, 2017

This doesn't have much of an impact, but some API calls would just return 't': None, 'a': None, g: None, 's': None and so on.

@mvdbeek mvdbeek added this to the 17.09 milestone Oct 3, 2017

@mvdbeek mvdbeek changed the base branch from dev to release_17.09 Oct 3, 2017

@dannon

This comment has been minimized.

Copy link
Member

commented Oct 3, 2017

This seems to work well to fix this particular case, and I saw we do something similar elsewhere.
I also noticed at least one other spot where this could be a problem, though, and we currently use a mix of lists and tuples. I'm going to open a PR to -dev following merging this to swap it all to lists, which work without the extra, empty tuple element forcing an iterator at that level.

@dannon dannon merged commit 0827b23 into galaxyproject:release_17.09 Oct 3, 2017

3 of 6 checks passed

api test Test started.
Details
framework test Test started.
Details
lgtm analysis: JavaScript Running analyses for revisions
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@mvdbeek mvdbeek deleted the mvdbeek:tags_fix branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.