Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Fix joiner tool to inherit datatype from the input format #4745

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
3 participants
@dannon
Copy link
Member

commented Oct 3, 2017

This should be output-format-identification as was the behavior prior to #4229 (yet using format_source instead of format, as was the intent in that change in the PR I think), but I'm not a tool author. Anything I'm missing here?

Without this, the outputs are just 'data' format, reported by @jennaj

@galaxybot galaxybot added the triage label Oct 3, 2017

@nsoranzo nsoranzo merged commit 7ce0d87 into galaxyproject:release_17.09 Oct 3, 2017

6 checks passed

api test Build finished. 292 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo added this to the 17.09 milestone Oct 4, 2017

@galaxyproject galaxyproject deleted a comment from galaxybot Oct 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.