New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many more upload tests. #4746

Merged
merged 3 commits into from Oct 4, 2017

Conversation

Projects
None yet
4 participants
@jmchilton
Member

jmchilton commented Oct 3, 2017

This extends #4563 and adds a bunch of new tests around upload - including deeper test coverage for the new feature in #4563 (trying different combinations, etc...) and new FTP upload integration tests with tests both for FTP upload configuration options (from galaxy.ini) and API options during FTP upload (space-to-tab, etc...).

jmchilton added some commits Oct 2, 2017

FTP upload integration tests.
Test various configuration options (ftp_upload_dir, ftp_upload_identifier, ftp_upload_dir_template) and various upload API parameters (space_to_tab, to_posix_lines, auto_decompress).

@martenson martenson merged commit f4eb2dc into galaxyproject:dev Oct 4, 2017

6 checks passed

api test Build finished. 303 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 55 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Member

jmchilton commented Oct 4, 2017

Thanks for the merge @martenson

@guerler

This comment has been minimized.

Contributor

guerler commented Oct 4, 2017

Thanks @jmchilton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment