Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Fix auth with ldaps:// #4748

Merged
merged 1 commit into from Oct 4, 2017

Conversation

Projects
None yet
4 participants
@abretaud
Copy link
Contributor

commented Oct 4, 2017

Update the python-ldap requirement, the new version allows connecting to ldaps:// now
See galaxyproject/starforge#146 and #3178

@galaxybot galaxybot added the triage label Oct 4, 2017

@galaxybot galaxybot added this to the 18.01 milestone Oct 4, 2017

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Oct 4, 2017

@abretaud I thought you wanted to target release_17.09?

@abretaud abretaud force-pushed the abretaud:ldap branch from 224c0ca to 096b387 Oct 4, 2017

@abretaud abretaud changed the base branch from dev to release_17.09 Oct 4, 2017

@abretaud

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2017

Oh yes, I forgot about it, I just changed the base branch (and rebased)

@nsoranzo nsoranzo changed the title Fix auth with ldaps:// [17.09] Fix auth with ldaps:// Oct 4, 2017

@nsoranzo nsoranzo modified the milestones: 18.01, 17.09 Oct 4, 2017

@abretaud

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2017

I don't remember how it works: do I need to make a PR against dev branch too?

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Oct 4, 2017

@abretaud No, don't worry, it will be merged forward by a committer after the PR is merged.

@jmchilton jmchilton merged commit d788bfb into galaxyproject:release_17.09 Oct 4, 2017

6 checks passed

api test Build finished. 292 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Oct 4, 2017

Awesome thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.