Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Force onload webhooks to wait for Galaxy object (and root) resolution. #4750

Merged

Conversation

Projects
None yet
3 participants
@dannon
Copy link
Member

commented Oct 4, 2017

This fixes onloadjs webhook loading on pages using older application templates, where Galaxy object initialization is delayed.

Not a long term solution, it'll go away as we finish migration towards modern app loading, but it should be a robust way to handle loading this for now.

In particular, one example this fixes is <galaxy>/library/list.

@jmchilton jmchilton merged commit 95d5ffc into galaxyproject:release_17.09 Oct 4, 2017

1 of 6 checks passed

api test Test started.
Details
framework test Test started.
Details
integration test Test started.
Details
lgtm analysis: JavaScript Running analyses for revisions
Details
toolshed test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@martenson martenson added this to the 17.09 milestone Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.