New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace admin toolshed repository grid mako #4755

Merged
merged 38 commits into from Oct 23, 2017

Conversation

Projects
None yet
3 participants
@guerler
Contributor

guerler commented Oct 4, 2017

This replaces the grid mako for installed toolshed repositories in the admin panel with the client form builder. In addition this PR removes the deprecated repository repair feature. This is step towards consolidating Galaxy's Toolshed Interface.

guerler added some commits Oct 4, 2017

@guerler guerler changed the title from Remove admin toolshed repository grid to Remove admin toolshed repository grid mako Oct 5, 2017

@guerler guerler added status/review and removed status/WIP labels Oct 16, 2017

@guerler guerler changed the title from Remove admin toolshed repository grid mako to Replace admin toolshed repository grid mako Oct 17, 2017

@guerler guerler added status/WIP and removed status/review labels Oct 17, 2017

@guerler guerler added status/review and removed status/WIP labels Oct 17, 2017

@guerler guerler requested a review from davebx Oct 17, 2017

@davebx

davebx approved these changes Oct 23, 2017

@davebx

This comment has been minimized.

Contributor

davebx commented Oct 23, 2017

I tested everything I could think of, and it all worked.

@dannon dannon merged commit 7f5048b into galaxyproject:dev Oct 23, 2017

6 checks passed

api test Build finished. 304 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Member

dannon commented Oct 23, 2017

rebuilt locally and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment