New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop running common_startup.sh twice when starting from run.sh #4759

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
2 participants
@natefoo
Member

natefoo commented Oct 5, 2017

Running twice doesn't break anything but it's unnecessary and presumably a mistake.

@jmchilton I assume this was just an oversight when the common startup functions were added?

@natefoo natefoo added this to the 18.01 milestone Oct 5, 2017

@jmchilton jmchilton merged commit d195ef8 into galaxyproject:dev Oct 5, 2017

4 of 6 checks passed

api test Test started.
Details
framework test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
integration test Build finished. 55 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Member

jmchilton commented Oct 5, 2017

Sorry about that.

@natefoo

This comment has been minimized.

Member

natefoo commented Oct 5, 2017

No problem, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment