Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] GIEs: Grandfather automatic uppercasing of some env_override variables #4760

Merged

Conversation

Projects
None yet
3 participants
@natefoo
Copy link
Member

commented Oct 5, 2017

Automatic loading of the launched-from dataset was broken by #4458, this restores that functionality without reverting the change made in #4458 by setting a list of "grandfathered" variables whose names will be automatically uppercased.

ping @erasche

@natefoo natefoo added this to the 17.09 milestone Oct 5, 2017

This was referenced Oct 5, 2017

@erasche

This comment has been minimized.

Copy link
Member

commented Oct 5, 2017

bandaids all the way down. Looks good to me. 👍

@martenson

This comment has been minimized.

Copy link
Member

commented Oct 5, 2017

TIL frozenset

@martenson martenson merged commit f9eae90 into galaxyproject:release_17.09 Oct 5, 2017

6 checks passed

api test Build finished. 292 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@natefoo

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2017

Thanks @erasche and @martenson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.