New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring linting. #4766

Merged
merged 1 commit into from Oct 8, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Member

jmchilton commented Oct 8, 2017

The module we used added a new issue D107 (lack of docstring in __init__ methods) which we fail extensively - so add it to the ignore list.

@galaxybot galaxybot added this to the 18.01 milestone Oct 8, 2017

@nsoranzo

This comment has been minimized.

Member

nsoranzo commented Oct 8, 2017

It seems you need to add also D106.

Fix docstring linting.
The module we used added new issues D106 and D107 (lack of docstring in __init__ methods) which we fail extensively - so adding it to the ignore list.

@nsoranzo nsoranzo merged commit 5edc423 into galaxyproject:dev Oct 8, 2017

6 checks passed

api test Build finished. 303 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 55 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@nsoranzo

This comment has been minimized.

Member

nsoranzo commented Oct 8, 2017

Thanks @jmchilton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment