Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused concept of dataset children. #4771

Merged
merged 1 commit into from Oct 11, 2017

Conversation

Projects
None yet
4 participants
@jmchilton
Copy link
Member

jmchilton commented Oct 9, 2017

We didn't really have any corresponding to active tools/histories, we know if they are present they break different parts of Galaxy (such as quota - not like incorrect quota but like breaking the history panel due to bad API requests). Lots of database joins and complexity we are not using and that is broken.

Remove unused concept of dataset children.
We didn't really have any corresponding to active tools, we know if they are present they break multiple different parts of Galaxy. Lots of database loads and complexity we are not using and that is broken.

@jmchilton jmchilton force-pushed the jmchilton:copy_children branch from e98d756 to d5b7141 Oct 9, 2017

@jmchilton jmchilton changed the title [WIP] Remove unused concept of dataset children. Remove unused concept of dataset children. Oct 9, 2017

@galaxybot galaxybot added this to the 18.01 milestone Oct 9, 2017

@guerler guerler merged commit d3345d9 into galaxyproject:dev Oct 11, 2017

6 checks passed

api test Build finished. 303 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 161 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@mvdbeek

This comment has been minimized.

Copy link
Member

mvdbeek commented on lib/galaxy/model/mapping.py in d5b7141 Jan 19, 2018

@jmchilton I think this causes #5345 ... are we sure this isn't used for copied or shared HDAs ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.