Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Collect extra files before declaring dataset's OK... #48

Merged
merged 1 commit into from Mar 30, 2015

Conversation

@jmchilton
Copy link
Member

jmchilton commented Mar 29, 2015

... so the files are available when you try to use them in immediately subsequent parts of an analysis.

@peterjc and I have both verified this fixes bugs in certain makeblastdb workflows - in a cluster and a localhost Docker setting respectively.

Opening to dev instead of release because the bug is 8 years old anyway and there is a chance fixing this exposes a new bug in some scenarios. For full details see - @bgruening and I have a plan to investigate this other potential bug before the next release.

... you know so they actually work when you try to use them in subsequent parts of the analysis.
@jmchilton

This comment has been minimized.

Copy link
Member Author

jmchilton commented on bdaa477 Mar 20, 2015

@peterjc , @bgruening. Ugh - if I could waste a little more of your guys' time - does this fix the problem? I think it should.

This comment has been minimized.

Copy link
Member Author

jmchilton replied Mar 20, 2015

On the upside though we caught this bug early - my best guess is it has been around only since 1aecfdb.

This comment has been minimized.

Copy link
Member

martenson replied Mar 20, 2015

lol, sweet 7 years

This comment has been minimized.

@dannon

This comment has been minimized.

Copy link
Member

dannon commented Mar 29, 2015

This is an automated message. Thanks for your contribution, a Trello card to track this issue has been created. Apply this patch for testing.

@bgruening

This comment has been minimized.

Copy link
Member

bgruening commented Mar 29, 2015

👍

@peterjc

This comment has been minimized.

Copy link
Contributor

peterjc commented Mar 29, 2015

+1 on merging (we'd been discussing this on email and Trello rather than here)

@natefoo

This comment has been minimized.

Copy link
Member

natefoo commented Mar 30, 2015

+1

1 similar comment
@martenson

This comment has been minimized.

Copy link
Member

martenson commented Mar 30, 2015

👍

martenson added a commit that referenced this pull request Mar 30, 2015
Bugfix: Collect extra files before declaring dataset's OK...
@martenson martenson merged commit c001570 into galaxyproject:dev Mar 30, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jmchilton jmchilton deleted the jmchilton:extra_files_race branch Nov 25, 2015
sveinugu added a commit to elixir-oslo/proto that referenced this pull request Apr 6, 2018
…lo_Ok3OM3td

Fixed bug for no overlap datasets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.