New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two invalid targets in dataset list item #4823

Merged
merged 1 commit into from Oct 18, 2017

Conversation

Projects
None yet
3 participants
@dannon
Member

dannon commented Oct 18, 2017

top vs _top -- which caused new windows opening instead of nav; down the road this'll just be router nav.

xref comments in #4819

Fix two invalid targets in dataset list item (top vs _top -- caused n…
…ew window instead of nav; eventually this'll just be router when everything is compatible)

@galaxybot galaxybot added this to the 18.01 milestone Oct 18, 2017

@martenson martenson merged commit 76d187a into galaxyproject:dev Oct 18, 2017

6 checks passed

api test Build finished. 304 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment