New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double return in form-parameters #4826

Merged
merged 2 commits into from Oct 18, 2017

Conversation

Projects
None yet
3 participants
@dannon
Member

dannon commented Oct 18, 2017

There's a return above that returns the actual object.

@dannon

This comment has been minimized.

Member

dannon commented Oct 18, 2017

@guerler Am I missing anything here?

@galaxybot galaxybot added the triage label Oct 18, 2017

@galaxybot galaxybot added this to the 18.01 milestone Oct 18, 2017

@guerler

This comment has been minimized.

Contributor

guerler commented Oct 18, 2017

Looks good. Thanks.

@guerler guerler merged commit be0541d into galaxyproject:dev Oct 18, 2017

6 checks passed

api test Build finished. 304 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript 1 fixed alert
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Member

dannon commented Oct 18, 2017

@guerler Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment