New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galaxy Tours - Grouping tours for viewing clarity #4829

Merged
merged 17 commits into from Oct 26, 2017

Conversation

Projects
None yet
6 participants
@selten
Contributor

selten commented Oct 18, 2017

These changes allow a large amount of galaxy tours to be shown in a clear way. Compared to the current list. The current list isn't that clear if you have over 10 tours. By grouping them, this clarity is greatly improved and the usability of galaxy tours for end users is vastly improved.

The implementation adds 2 extra parameter to each tour, namely group and group_name. 'group' is the identifier for the group. 'group_name' is the name that is used for displaying the group. This implementation groups the tours and displays them as groups.

The changes can be tested by going to the interactive tours and seeing that they are grouped. A <ul> in the group <li>.

selten added some commits Oct 18, 2017

Delete test.yaml
Accidentally added file to GIT for design checking.

@galaxybot galaxybot added the triage label Oct 18, 2017

@galaxybot galaxybot added this to the 18.01 milestone Oct 18, 2017

@bgruening

This comment has been minimized.

Member

bgruening commented Oct 18, 2017

@selten this is awesome. Does this mean that you are using tours heavily? :)
Have you considered to use simple tags as in other parts of Galaxy. The UI could then try to group the tags or offer a filter for the tags, like in workflows etc...

@dannon

This comment has been minimized.

Member

dannon commented Oct 18, 2017

@bgruening I was thinking the same thing. I'd love to see some sort of 'domain tags' or the like, and have the tours UI automatically generate these groups.

@selten

This comment has been minimized.

Contributor

selten commented Oct 18, 2017

I haven't considered using tags because I never developed for the galaxy core. That could be a great change though. I'll look into this later. Thank you for the advice.

@jmchilton

This comment has been minimized.

Member

jmchilton commented Oct 19, 2017

@galaxybot test this

@dannon dannon added area/UI-UX status/WIP and removed triage labels Oct 19, 2017

@dannon

This comment has been minimized.

Member

dannon commented Oct 19, 2017

@selten I really like where this is headed. Let me know if you want any help with the tag implementation. Instead of 'group' and 'group_name', I'm thinking we could just have a single list at the top level of the tour like:

...
tour_id: my_workflow
tags:
    - Beginner
    - Workflows
...

Tags like this would keep it simple, yet flexible, and would require less coordination across the community on naming I think.

Edit: One other benefit would be that we wouldn't be changing the API response quite as dramatically, either. I doubt this is a heavily consumed API (currently), but this is something to keep in mind. In this implementation api/tours is changed to actually provide a list of groups, which doesn't seem correct to me. I think I'd like to see the tags approach, with this endpoint providing a list of tours as expected, just with the additional tags field.

@dannon dannon self-requested a review Oct 19, 2017

@jmchilton

This comment has been minimized.

Member

jmchilton commented Oct 19, 2017

@galaxybot test this

@dannon dannon added status/review and removed status/WIP labels Oct 24, 2017

@dannon

This comment has been minimized.

Member

dannon commented Oct 24, 2017

@selten Thanks, I'll check this out today!

@martenson

This comment has been minimized.

Member

martenson commented Oct 24, 2017

@galaxybot test this

Merge pull request #2 from dannon/selten_dev
A few more tweaks to tours
@dannon

This comment has been minimized.

Member

dannon commented Oct 24, 2017

@galaxybot test this

@dannon

dannon approved these changes Oct 24, 2017

@dannon dannon merged commit 89e8437 into galaxyproject:dev Oct 26, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: JavaScript No alert changes
Details
@dannon

This comment has been minimized.

Member

dannon commented Oct 26, 2017

@selten Thanks for this, it's a great start towards better tour organization!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment