New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose state, stdout, stderr, uuid in the library API #4839

merged 2 commits into from Oct 25, 2017



martenson commented Oct 20, 2017

and in the UI, fix few bugs and UI/UX glitches

expose state, stdout, stderr, uuid in the API
fix few bugs and UI/UX glitches
# Manage dataset permission is always attached to the dataset itself, not the the ld or ldda to maintain consistency
rval['can_user_manage'] =, ld.library_dataset_dataset_association.dataset) or trans.user_is_admin()
rval['can_user_manage'] =, ldda.dataset) or trans.user_is_admin()

This comment has been minimized.


nsoranzo Oct 23, 2017


It may be faster to swap the conditions:

trans.user_is_admin() or, ldda.dataset)

This comment has been minimized.


jmchilton Oct 25, 2017


Good catch!


This comment has been minimized.


martenson commented Oct 24, 2017

@galaxybot test this

@jmchilton jmchilton merged commit 0f5927b into galaxyproject:dev Oct 25, 2017

3 of 6 checks passed

api test Build finished. 304 tests run, 4 skipped, 10 failed.
integration test Test started.
toolshed test Test started.
continuous-integration/travis-ci/pr The Travis CI build passed
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
lgtm analysis: JavaScript No alert changes

@martenson martenson deleted the martenson:library-expose-state branch Oct 25, 2017

@martenson martenson moved this from Done to Closed in Data Libraries Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment