New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all E722 errors and ignore E741 #4847

Merged
merged 1 commit into from Oct 24, 2017

Conversation

Projects
None yet
2 participants
@nsoranzo
Member

nsoranzo commented Oct 23, 2017

Introduced in flake8 3.5.0

@@ -16,7 +16,7 @@
try:
from uwsgidecorators import postfork as uwsgi_postfork
except:
except ImportError:

This comment has been minimized.

@nsoranzo

nsoranzo Oct 23, 2017

Member

Add AttributeError

@nsoranzo nsoranzo changed the title from Fix all E722 errors and ignore E741 to [WIP] Fix all E722 errors and ignore E741 Oct 24, 2017

@nsoranzo nsoranzo added status/WIP and removed status/review labels Oct 24, 2017

Fix all E722 errors and ignore E741
Introduced in flake8 3.5.0
Fix import order.

@nsoranzo nsoranzo added status/review and removed status/WIP labels Oct 24, 2017

@nsoranzo nsoranzo changed the title from [WIP] Fix all E722 errors and ignore E741 to Fix all E722 errors and ignore E741 Oct 24, 2017

@jmchilton jmchilton merged commit 62826a1 into galaxyproject:dev Oct 24, 2017

5 of 6 checks passed

api test Build finished. 304 tests run, 4 skipped, 10 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:flake8_3.5.0 branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment