Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated QUnit testing. #4855

Merged
merged 1 commit into from Oct 26, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

jmchilton commented Oct 24, 2017

  • Update to QUnit from 1.23 to 2.0.
  • Update Sinon from 1.17 to 4.0.1.
  • Replace sinon-qunit with just basic calls to sinon itself (sinon-qunit not compatible with QUnit 2.0).
  • Replace all QUnit globals with dependency injected values (a lot of this had to be done for QUnit 2.0 anyway).
  • Improved error reporting in test-common.js if things don't go well loading modules.
  • Improved verbose logging in test Gruntfile.
  • Replace in-repo sinon and QUnit asserts (JS/CSS) with npm packges.

@jmchilton jmchilton force-pushed the jmchilton:qunit_2.0 branch from db0be54 to d653ba9 Oct 24, 2017

@galaxybot galaxybot added this to the 18.01 milestone Oct 24, 2017

Updated QUnit testing.
- Update to QUnit from 1.23 to 2.0.
- Update Sinon from 1.17 to 4.0.1.
- Replace sinon-qunit with just basic calls to sinon itself (sinon-qunit not compatible with QUnit 2.0).
- Replace all QUnit globals with dependency injected values (a lot of this had to be done for QUnit 2.0 anyway).
- Improved error reporting in test-common.js if things don't go well loading modules.
- Improved verbose logging in test Gruntfile.
- Replace in-repo sinon and QUnit asserts (JS/CSS) with npm packges.

@jmchilton jmchilton force-pushed the jmchilton:qunit_2.0 branch from d653ba9 to ada0be1 Oct 25, 2017

@martenson martenson merged commit 82df013 into galaxyproject:dev Oct 26, 2017

6 checks passed

api test Build finished. 304 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.