New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple tests for data source responses. #4863

Merged
merged 2 commits into from Oct 26, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Member

jmchilton commented Oct 25, 2017

  • Verify a simple data source works when responding via the API.
  • Verify a data source sending back a file:// parameter is blocked (GX-2017-0004/GX-2017-0003 - it is tracked different ways in the commit message and in the security issue tracker).
Simple tests for data source responses.
- Verify a simple data source works when responding via the API.
- Verify a data source sending back a file:// parameter is blocked (GX-2017-0004/GX-2017-0003 - it is tracked different ways in the commit message and in the security issue tracker).

@jmchilton jmchilton added this to the 18.01 milestone Oct 25, 2017

Fix tool XSD for data source tools.
I guess it has never been applied to a data source?
@jmchilton

This comment has been minimized.

Member

jmchilton commented Oct 26, 2017

Updated the XSD since Travis applies it to all framework test tools including this new one and discovered the XSD for data sources is a little off.

@natefoo

This comment has been minimized.

Member

natefoo commented Oct 26, 2017

Thank you!

@natefoo natefoo merged commit 800a7fa into galaxyproject:dev Oct 26, 2017

6 checks passed

api test Build finished. 306 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment