New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various elements to the Tool XML doc page #4871

Merged
merged 1 commit into from Oct 26, 2017

Conversation

Projects
None yet
2 participants
@nsoranzo
Member

nsoranzo commented Oct 26, 2017

In particular:

  • macros
  • edam_topics
  • edam_operations
  • environment_variables and subelement
  • request_param_translation and subelements

Also:

  • reorder elements to follow IUC coding style
  • in examples:
    • use lowercase true and false for boolean attributes
    • add/use single quotes
  • minor doc fixes
Add various elements to the Tool XML doc page
In particular:
- macros
- edam_topics
- edam_operations
- environment_variables and subelement
- request_param_translation and subelements

Also:
- reorder elements to follow IUC coding style
- in examples:
  - use lowercase ``true`` and ``false`` for boolean attributes
  - add/use single quotes
- minor doc fixes
$tag:tool|configfiles|inputs://complexType[@name='ConfigInputs']
$tag:tool|environment_variables://complexType[@name='EnvironmentVariables']
$tag:tool|environment_variables|environment_variable://complexType[@name='EnvironmentVariable']
$tag:tool|request_param_translation://complexType[@name='RequestParameterTranslation']

This comment has been minimized.

@jmchilton

jmchilton Oct 26, 2017

Member

I'm kind of -0 on indexing these elements in this way. I didn't index them intentionally - but perhaps that was the wrong choice on my part.

This comment has been minimized.

@nsoranzo

nsoranzo Oct 26, 2017

Member

Is there any other way?
Also, if someone has to write a data_source tool, they need this info.

@jmchilton

This comment has been minimized.

Member

jmchilton commented Oct 26, 2017

This is fantastic - thanks for this! This is a huge improvement overall and really appreciated.

@jmchilton jmchilton merged commit efc9dbf into galaxyproject:dev Oct 26, 2017

6 checks passed

api test Build finished. 306 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:tool_schema_improv branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment