Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Absolute pins on linting dependencies. #4876
referenced this pull request
Oct 26, 2017
I mean I just installed it into the virtualenv but that wouldn't be best practice I don't think. I guess a standalone installation would be ideal but not needed. Any particular reason we can push up our pin of requirements that you know of?
Also I don't necessarily think people need to install pipenv yet right? I'm generating backward compatible requirements.txt files for this and the other PR. You don't need pipenv to run the linting at all - just to generate the artifacts in the repo - which only needs one person to update them every month or two.
Back to the requests point - I've opened a starforge PR that updates a few various dependencies - maybe we can get a new version of some of these dependencies in Galaxy.
This was referenced
Oct 27, 2017
Bus factor, you know... It would be good if all committers can do that.
I tried to install pipenv in my Galaxy virtualenv and it messed it up completely, had to recreate it. I ended up using:
from outside of all virtualenvs.