New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sorting options for data library folders #4877

Merged
merged 6 commits into from Oct 30, 2017

Conversation

2 participants
@martenson
Member

martenson commented Oct 26, 2017

I refactored the comparators to new util class. Moreover it should now work even when sort_key is missing from some of the objects (because we are sorting on a collection of heterogenous objects).

that admin-panel.js is just 'prettier'

martenson added some commits Oct 25, 2017

@martenson martenson added this to the 18.01 milestone Oct 26, 2017

@martenson martenson added this to Done in Data Libraries Oct 26, 2017

martenson added some commits Oct 27, 2017

datalibs add func to sort folder by desc/state
refactor the comparator a bit to not change the actual obejcts' prperties
@martenson

This comment has been minimized.

Member

martenson commented Oct 27, 2017

I tweaked the comparator once again and added sorting to state/description properties

@martenson martenson changed the title from add sorting on datatype in data library folder to add sorting options for data library folders Oct 27, 2017

@dannon dannon merged commit 6263740 into galaxyproject:dev Oct 30, 2017

6 checks passed

api test Build finished. 306 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@martenson martenson deleted the martenson:lib-comparators branch Oct 30, 2017

@martenson martenson moved this from Done to Closed in Data Libraries Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment