New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list collection creator dragdrop event bindings. #4901

Merged
merged 2 commits into from Nov 1, 2017

Conversation

Projects
None yet
3 participants
@dannon
Member

dannon commented Oct 30, 2017

I'm still not 100% sure what precisely broke in the jquery-via-backbone bindings, but using plain old javascript bindings works well here. The culprit is likely the jquery upgrade performed as a part of the es6 update.

Fixes #4888

@dannon dannon added the kind/bug label Oct 30, 2017

@dannon

This comment has been minimized.

Member

dannon commented Oct 30, 2017

Looks like the same problem in the paired list dragndrop functionality; taking a look now.

Handle same as previous commit's jquery-backbone-binding-fail with st…
…andard event binding in list of pairs collection builder.
@dannon

This comment has been minimized.

Member

dannon commented Oct 30, 2017

Obviously some duplication here between the two collection creators, but that's not new (though these changes don't make it any better). This is a bugfix for broken functionality, but I need to look into this on a broader scope and see why these draggable bindings are different from the basemvc mixin for similar functionality.

@galaxybot galaxybot added this to the 18.01 milestone Oct 30, 2017

@jmchilton

This comment has been minimized.

Member

jmchilton commented Nov 1, 2017

Wonderful - thanks for the fix!

@jmchilton jmchilton merged commit 4d3382f into galaxyproject:dev Nov 1, 2017

6 checks passed

api test Build finished. 306 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment