New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium test for Tool-Describing-Tours #4909

Merged
merged 10 commits into from Nov 15, 2017

Conversation

Projects
None yet
6 participants
@anatskiy
Contributor

anatskiy commented Nov 1, 2017

This PR adds a simple test for Tool-Describing-Tours, which checks whether a tour can be generated.

The webhooks path must be overridden before running the test:

export GALAXY_CONFIG_OVERRIDE_WEBHOOKS_DIR=$GALAXY_DIRECTORY/config/plugins/webhooks/demo

anatskiy added some commits Oct 17, 2017

Merge branch 'dev' into tdt_tests
# Conflicts:
#	client/galaxy/scripts/mvc/tool/tool-form-base.js
#	static/maps/mvc/tool/tool-form-base.js.map
#	static/scripts/bundled/analysis.bundled.js
#	static/scripts/bundled/analysis.bundled.js.map
#	static/scripts/bundled/libs.bundled.js.map
#	static/scripts/mvc/tool/tool-form-base.js

@galaxybot galaxybot added the triage label Nov 1, 2017

@galaxybot galaxybot added this to the 18.01 milestone Nov 1, 2017

jmchilton added some commits Nov 15, 2017

Improvements for tour generator Selenium tests.
- Replace test using Cut1 with two tests each using framework test tools loaded with Selenium tests by default.
- Create a symbolic link so that tour generator is configured with default test webhooks.
- Establish and use components and navigates_galaxy.py abstractions for tour generation and navigation.
- In one of the tool tests actually walk the tour (previously we only verified the initial tour popover).
@jmchilton

This comment has been minimized.

Member

jmchilton commented Nov 15, 2017

@galaxybot test this

@jmchilton

This comment has been minimized.

Member

jmchilton commented Nov 15, 2017

@anatskiy Thanks for this - awesome stuff! I pushed a bunch stuff into your branch that hope maximize the utility of this great work. In short:

  • I merged with dev - where it turns out we totally broke TDTs this development cycle (this test case would have caught that - so awesome!). cecef90
  • I pushed a fix for TDTs - the other webhooks may need to be likewise updated - but I don't know. fb91302
  • I replaced the test using Cut1 with two tests each using framework test tools loaded with Selenium tests by default - this makes it easier to run these as part of our CI Jenkins setup.
  • I created a symbolic link so that tour generator is configured with default test webhooks. Together with the above change - this means these tests will now run for every PR after merged.
  • I established and used components and navigates_galaxy.py abstractions for tour generation and navigation based on the work you had.
  • In one of the tool tests actually walk the tour (previously we only verified the initial tour popover).
  • I used the infrastructure from #4971 to capture some screenshots of tours as they run - so hopefully we will be able to visually inspect the tour running after after Jenkins is done.
@jmchilton

This comment has been minimized.

Member

jmchilton commented Nov 15, 2017

And it works... the tests were included in the Jenkins Selenium tests that are green here and the following screenshots of a test tour were generated:

@anatskiy

This comment has been minimized.

Contributor

anatskiy commented Nov 15, 2017

@jmchilton oh, wow, thanks a lot for these cool improvements!

@anatskiy

This comment has been minimized.

Contributor

anatskiy commented Nov 15, 2017

I pushed a fix for TDTs - the other webhooks may need to be likewise updated

@jmchilton nope, no other webhook uses the Tours module.

@dannon

This comment has been minimized.

Member

dannon commented Nov 15, 2017

Nice, looks good!

(and, it's not the Tours module specifically, it's how the es6 module exports changed when used from require(); I definitely got everything in client and templates, but am checking through config now. Followup: Looks like the only other ones were IES, which I already fixed as a part of the main branch, only TDTs got forgotten)

@dannon dannon merged commit 54c6a79 into galaxyproject:dev Nov 15, 2017

7 checks passed

api test Build finished. 310 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 100 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@bgruening bgruening deleted the anatskiy:tdt_tests branch Nov 15, 2017

@bgruening

This comment has been minimized.

Member

bgruening commented Nov 15, 2017

Cool thanks a lot all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment