New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status handling for grids #4913

Merged
merged 3 commits into from Nov 2, 2017

Conversation

Projects
None yet
4 participants
@guerler
Contributor

guerler commented Nov 1, 2017

Fixes the status handling for grid messages. Ping @martenson. Does this fix the issue you mentioned in #4833? Thanks for reporting it.

@guerler guerler added this to the 18.01 milestone Nov 1, 2017

@dannon

This comment has been minimized.

Member

dannon commented Nov 1, 2017

This looks like it should fix it to me.

@jmchilton

This comment has been minimized.

Member

jmchilton commented Nov 1, 2017

Sorry about the broken tests - I'm looking into it.

@martenson

This comment has been minimized.

Member

martenson commented Nov 1, 2017

with this PR after trying to update TS status of a repo I get this in the JS console

Uncaught ReferenceError: str is not defined
    at Object.message (grid-template.js:443)
    at L.n.init_grid (grid-view.js:118)
    at Object.success (grid-view.js:719)
    at l (jquery.js:3187)
    at Object.fireWith [as resolveWith] (jquery.js:3317)
    at n (jquery.js:8757)
    at XMLHttpRequest.<anonymous> (jquery.js:9123)
@dannon

This comment has been minimized.

Member

dannon commented Nov 1, 2017

I think @martenson's error is the line before; String vs str.

@guerler

This comment has been minimized.

Contributor

guerler commented Nov 1, 2017

Thx I fixed that.

@jmchilton

This comment has been minimized.

Member

jmchilton commented Nov 2, 2017

Is it surprising or not surprising at all that I was sitting here debugging Selenium tests in dev and noticed this str thing in the error logs. This fixes Selenium tests that are broken in dev. I need to get my act together on testing these PRs - we would have caught this ahead of time.

Thanks for the fix @guerler!

@jmchilton jmchilton merged commit 155ed58 into galaxyproject:dev Nov 2, 2017

6 checks passed

api test Build finished. 306 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@jmchilton jmchilton referenced this pull request Nov 2, 2017

Merged

ES6 broad pass overhaul #4827

@guerler

This comment has been minimized.

Contributor

guerler commented Nov 2, 2017

Me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment