Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downloading of arbitrarily-nested collections #4934

Merged
merged 1 commit into from Nov 5, 2017

Conversation

Projects
None yet
2 participants
@mvdbeek
Copy link
Member

commented Nov 5, 2017

This should work for any level of nesting and includes tests for the list:list
and list:list:list case. That's a first step towards #4415.

@jmchilton

This comment has been minimized.

Copy link
Member

commented Nov 5, 2017

I've been trying to debug a new PR watcher for Selenium tests today - sorry if the status turns red over that. I'll merge regardless obviously - looks awesome - thanks for working on this.

Fix downloading of arbitrarily-nested collections
This should work for any level of nesting and includes tests for the list:list
and list:list:list case. That's a first step towards #4415.

@mvdbeek mvdbeek force-pushed the mvdbeek:download_list_list branch from 94a2760 to 611b667 Nov 5, 2017

@jmchilton jmchilton merged commit 128b0a2 into galaxyproject:dev Nov 5, 2017

7 checks passed

api test Build finished. 309 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 98 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Nov 5, 2017

Awesome - thanks so much!

@mvdbeek mvdbeek deleted the mvdbeek:download_list_list branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.