Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Galaxy client logging during Selenium tests. #4935

Merged
merged 2 commits into from Nov 6, 2017

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

jmchilton commented Nov 5, 2017

  • Use localStorage to enable the logs at the start of new connections during tests.
  • Add new flatten console logging options in the client to hack around problem recovering multiple argument style logging the client uses with only getting back first argument when using Selenium API (at least with Chrome).
  • Break out the browser log into a sort of default and verbose mode (only the latter includes DEBUG and INFO messages).
  • Use json.dump with the indent call to get more visually parsable logging messages in the Selenium test failure dump.

To manually testing this - just open test/selenium_tests/test_anon_history.py, throw an assert False at the end of the first test, run the test with nosetests test/selenium_tests/test_anon_history.py:AnonymousHistoriesTestCase.test_anon_history_landing (after sourcing Galaxy's virtualenv), wait for the test to fail, and then look for the files produced on failure in database/test_errors for this test. browser.log.verbose.log should have a bunch of stuff in there.

jmchilton added some commits Nov 4, 2017

Enable galaxy logging during Selenium tests.
- Use localStorage to enable the logs at the start of new connections during tests.
- Add new flatten console logging options in the client to hack around problem recovering multiple argument style logging the client uses with only getting back first argument when using Selenium API (at least with Chrome).
- Break out the browser log into a sort of default and verbose mode (only the latter includes DEBUG and INFO messages).
- Use json.dump with the indent call to get more visually parsable logging messages in the Selenium test failure dump.
@dannon

This comment has been minimized.

Copy link
Member

dannon commented Nov 6, 2017

+1, good idea.

@dannon dannon merged commit ff5c551 into galaxyproject:dev Nov 6, 2017

7 checks passed

api test Build finished. 307 tests run, 5 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 98 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.