New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow downloading collections (through UI) at arbitrary levels of nesting #4942

Merged
merged 3 commits into from Nov 6, 2017

Conversation

Projects
None yet
2 participants
@mvdbeek
Member

mvdbeek commented Nov 6, 2017

For this to work I added an API route for downloading dataset collections directly through /api/dataset_collections/{id}/download, instead of /api/histories/{history_id}/contents/{id}/download (which didn't really require the history_id anyway).
This closes #4415

@dannon

This comment has been minimized.

Member

dannon commented Nov 6, 2017

Nice, just tried this locally and it works well! I think we might be able to come up with a better location for the download icon (but I don't have one in mind currently), so I'm going to go ahead and merge this.

@dannon dannon merged commit 63a3fa4 into galaxyproject:dev Nov 6, 2017

7 checks passed

api test Build finished. 309 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 57 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript No alert changes
Details
selenium test Build finished. 98 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@mvdbeek mvdbeek deleted the mvdbeek:fix_download_button branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment